Strange warmup timing tables

Discuss software bugs and related problems here.

Moderator: Matt

Shaker
Posts: 26
Joined: Wed Sep 23, 2015 8:00 pm
Location: Germany
Contact:

Strange warmup timing tables

Postby Shaker » Sat Sep 24, 2016 12:13 pm

Hello.

I have 4 problems in 4 warmup timing tables. At least something illogical is going on here.
1) In this version 2 tables have exactly the same name and the same content or relation (RPM - degrees).
2) The "Warmup timing (conditional)" has a wrong RPM scale. When other tables / maps are on 1200 (log playback), this is on 600.
3) 2 tables seem to access the same register. When you change the "Warmup timing (conditional)" and (re-)open the 2nd "After Start Timing Advance", you can see, that its value has also changed.
4) The 2 tables from point 3) use different filters, or better - the "After Start Timing Advance" doesn't seem to be using any filter. Both marked cells are are on 10 degrees, but the one shows 26, even though both are on "Filtered values".

The picture might make clear what I mean.
As you can see, it's a CA18DET.
Part number -39F00.

Can you please tell me if I'm right and would you target this for the next release?
Attachments
S13 Warmup timings+.png
S13 Warmup timings+.png (247.6 KiB) Viewed 1944 times

Matt
Site Admin
Posts: 8046
Joined: Sun Jan 29, 2006 1:45 am
Location: Adelaide, Australia
Contact:

Re: Strange warmup timing tables

Postby Matt » Tue Sep 27, 2016 9:09 pm

Inside BASE_CA_128_E.adr

1. These are duplicates:
AFTER_START_TIMING_ADVANCE,&H39B0,8,1,8,1 (remove)
AFTER_START_TIMING_ADVANCE2,&H39B0,8,1,8,1 (remove)
Imported by S13_CA18DET_128_E.adr

2. WARMUP_TIMING,&H3B90,8,1,8,1 is indexed RAM_1044_RPM_MSB

3. Correct address IDLE_TIMING,&H39B0,32,1,32,1,Idle Ignition Neutral Timing
Indexed differently: RAM_10E8_RPMLSBDiv2

Explains different scales

HIGH_TIMING_ADVANCE_BETA,&H3B20,8,1,8,1 this one is indexed by coolant temp (RAM_105F_CoolantTempIdx) so table needs to be fixed for this ECU

Shaker
Posts: 26
Joined: Wed Sep 23, 2015 8:00 pm
Location: Germany
Contact:

Re: Strange warmup timing tables

Postby Shaker » Sat Oct 01, 2016 12:00 am

Thanks for your reply!

But what are you trying to tell me? Are you explaining things or telling me, that I am wrong at certain points?
1) In my "BASE_CA_128_E.adr" it looks like this:
AFTER_START_TIMING_ADVANCE,&H39B0,8,1,8,1
AFTER_START_TIMING_ADVANCE2,&H3B90,8,1,8,1
What do you mean be "remove"? Should both be removed, because they have no effect on the CA18DET?

2) When WARMUP_TIMING has &H3B90, which I can see in my S13_CA18DET_128_E.adr", then it explains, why it affects AFTER_START_TIMING_ADVANCE2 (3B90 in both cases). Maybe this was a typo once? I haven't changed anything here and made all the updates that came up.
What do you mean by "RAM_1044_RPM_MSB"? I can't see that anywhere. What can I do against the wrong scale?

3) What does your answer tell me? I am not talking about IDLE_TIMING. WARMUP_TIMING has the wrong scale...

If AFTER_START_TIMING_ADVANCE and IDLE_TIMING are the same (it look's like this in practice), why do I need both? Can't I delete AFTER_START_TIMING_ADVANCE e.g. to clean things a little bit up?
What does 32,1,32,1 and 8,1,8,1 stand for?
// EDIT: Ok, "32,1" stands for the table dimensions followed by the field count (32x1 = 32), but the 4th digit? 32,1,32,?

What about point 4, the filter?

Ok, to sum it up:
IDLE_TIMING,&H39B0,32,1,32,1,Idle Ignition Neutral Timing (S13_CA18DET_128_E.adr)
WARMUP_TIMING,&H3B90,8,1,8,1 (S13_CA18DET_128_E.adr)
AFTER_START_TIMING_ADVANCE,&H39B0,8,1,8,1 ("BASE_CA_128_E.adr")
AFTER_START_TIMING_ADVANCE2,&H3B90,8,1,8,1 ("BASE_CA_128_E.adr")

These are the values in my case.

Matt
Site Admin
Posts: 8046
Joined: Sun Jan 29, 2006 1:45 am
Location: Adelaide, Australia
Contact:

Re: Strange warmup timing tables

Postby Matt » Tue Oct 18, 2016 6:58 pm

I've made notes against the changes required. Will update in next release once I've finished going through them

Matt
Site Admin
Posts: 8046
Joined: Sun Jan 29, 2006 1:45 am
Location: Adelaide, Australia
Contact:

Re: Strange warmup timing tables

Postby Matt » Wed Oct 26, 2016 12:09 am

Resolved in new update 1.2.54

Shaker
Posts: 26
Joined: Wed Sep 23, 2015 8:00 pm
Location: Germany
Contact:

Re: Strange warmup timing tables

Postby Shaker » Wed Oct 26, 2016 8:21 pm

Thank you very much for this, but what I am already using 1.2.62. Are you sure about version 1.2.54? I think, it's 1.2.64.

For anyone interested in the changes in the .adr files in detail (and for me to understand the changes :D ):
OLD:
AFTER_START_TIMING_ADVANCE,&H39B0,8,1,8,1 ("BASE_CA_128_E.adr") = IDLE_TIMING,&H39B0,32,1,32,1 (S13_CA18DET_128_E.adr) - duplicate

AFTER_START_TIMING_ADVANCE2,&H3B90,8,1,8,1 ("BASE_CA_128_E.adr") = WARMUP_TIMING,&H3B90,8,1,8,1 (S13_CA18DET_128_E.adr) - duplicate

NEW:
AFTER_START_TIMING_ADVANCE,&H39B0,8,1,8,1 ("BASE_CA_128_E.adr") - hidden in "S13_CA18DET_128_E.adr".
And hereby replaced by IDLE_TIMING,&H39B0,32,1,32,1 (S13_CA18DET_128_E.adr)

AFTER_START_TIMING_ADVANCE2,&H3B90,8,1,8,1 ("BASE_CA_128_E.adr") - removed!
And hereby replaced by WARMUP_TIMING,&H3B90,8,1,8,1 (S13_CA18DET_128_E.adr)

resulting in:
no more AFTER_START_TIMING_ADVANCE
IDLE_TIMING
WARMUP_TIMING

plus some more WARMUP_TIMING_... tables and a change from IDLE_TIMING_GEAR into IDLE_TIMING_WARM_OFFSET

Shaker
Posts: 26
Joined: Wed Sep 23, 2015 8:00 pm
Location: Germany
Contact:

Re: Strange warmup timing tables

Postby Shaker » Wed Oct 26, 2016 9:03 pm

Excuse me, 2 things left in version 1.2.64:
I think, a scale is not yet correct and he window title does not match the menu on the side:
nistune 1.2.64 screenshot+.png
nistune 1.2.64 screenshot+.png (47.11 KiB) Viewed 1861 times

Matt
Site Admin
Posts: 8046
Joined: Sun Jan 29, 2006 1:45 am
Location: Adelaide, Australia
Contact:

Re: Strange warmup timing tables

Postby Matt » Mon Oct 31, 2016 6:02 pm

Fixed next release

Shaker
Posts: 26
Joined: Wed Sep 23, 2015 8:00 pm
Location: Germany
Contact:

Re: Strange warmup timing tables

Postby Shaker » Tue Nov 01, 2016 4:09 am

Wonderful, thank you


Return to “Software Bugs”

Who is online

Users browsing this forum: No registered users and 4 guests